From ba4c3a6f988beff59e45801ab36067293d24ce92 Mon Sep 17 00:00:00 2001 From: Patrick Griffis Date: Wed, 8 Jan 2025 16:30:17 -0600 Subject: [PATCH] content-sniffer: Handle sniffing resource shorter than 4 bytes Upstream-Status: Backport [https://gitlab.gnome.org/GNOME/libsoup/-/commit/ba4c3a6f988beff59e45801ab36067293d24ce92] CVE: CVE-2025-32909 Signed-off-by: Vijay Anusuri --- libsoup/content-sniffer/soup-content-sniffer.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/libsoup/content-sniffer/soup-content-sniffer.c b/libsoup/content-sniffer/soup-content-sniffer.c index 5a181ff1..aeee2e25 100644 --- a/libsoup/content-sniffer/soup-content-sniffer.c +++ b/libsoup/content-sniffer/soup-content-sniffer.c @@ -243,9 +243,14 @@ sniff_mp4 (SoupContentSniffer *sniffer, GBytes *buffer) gsize resource_length; const char *resource = g_bytes_get_data (buffer, &resource_length); resource_length = MIN (512, resource_length); - guint32 box_size = *((guint32*)resource); + guint32 box_size; guint i; + if (resource_length < sizeof (guint32)) + return FALSE; + + box_size = *((guint32*)resource); + #if __BYTE_ORDER__ == __ORDER_LITTLE_ENDIAN__ box_size = ((box_size >> 24) | ((box_size << 8) & 0x00FF0000) | -- GitLab