From 02aa0f9bad3d9e47a152fc045d0f51874d901d7e Mon Sep 17 00:00:00 2001 From: "Sicelo A. Mhlongo" Date: Wed, 4 Dec 2024 10:18:51 +0200 Subject: [PATCH] smsutil: check deliver reports fit in buffer Fixes CVE-2023-4235 CVE: CVE-2023-4235 Upstream-Status: Backport [https://git.kernel.org/pub/scm/network/ofono/ofono.git/commit/?id=02aa0f9bad3d9e47a152fc045d0f51874d901d7e] Signed-off-by: Peter Marko --- src/smsutil.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/smsutil.c b/src/smsutil.c index 484bfd0b..ac89f16c 100644 --- a/src/smsutil.c +++ b/src/smsutil.c @@ -1240,10 +1240,16 @@ static gboolean decode_deliver_report(const unsigned char *pdu, int len, return FALSE; if (out->type == SMS_TYPE_DELIVER_REPORT_ERROR) { + if (expected > (int) sizeof(out->deliver_err_report.ud)) + return FALSE; + out->deliver_err_report.udl = udl; memcpy(out->deliver_err_report.ud, pdu + offset, expected); } else { + if (expected > (int) sizeof(out->deliver_ack_report.ud)) + return FALSE; + out->deliver_ack_report.udl = udl; memcpy(out->deliver_ack_report.ud, pdu + offset, expected); -- 2.30.2